The committers listed above are authorized under a signed CLA.

• ✅ login: yijie-04 / name: Yijie Wang (0bf2982, 94cd51b, a82c2aa, d4bfe4e, 979911d, bbefcc2, de30fc5, ce5a778, 2ae1090, 695e58c, efc1cc3, 37f0dff, a414f3e, de787c6, c365d4a, 7d73360, c048610, 3d3bd2c, f5d583f, d934231, 08dbe1e, d3205ab, a31fc39, b69cc29, 51befc7, e95329e, e76634a, 8e112d8, c04375a, d7f6e43, f2fe553, b2941ac, 5244f19, 2c94ec7, 3d0d399, 8c30426, bee47f4, 5c25449, 63346a6, 9a44a73)
• ✅ login: Zazzscoot / name: Scott Hirano (17c775a)

Welcome @yijie-04! It looks like this is your first PR to knative/eventing 🎉

Hi @yijie-04. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

@yijie-04 Thanks for the PR!
As this is your very first PR in the LFX(linux fundation) community, please make sure you complete the EasyCLA so that you are authorized to contribute to Knative.

Here is the link on what is EasyCLA and how to complete it.

@yijie-04 Replying your DM here so others can also benefit from this! Usually when you complete the EasyCLA authorization, check in the GitHub action should turn green immediately. If that doesn't change, there is probably something wrong. Please make sure the github account you used for this PR and the one you used with CLA are the same. Let me know if that helps!

@yijie-04 Hello Yijie! Are there anything that blocking you? Any help I can provide you with?

@Leo6Leo Thank you for checking in! It took me a bit of time to debug the unit-tests and it turned out to be simpler than I thought! I'm looking at the other tests right now and it seems that I'm receiving the timeout waiting for pods to come up error. Do you have any suggestions on how I can approach this?

@yijie-04 Hey Yijie, no problem, that's happened to me a lot too! Replying to your question, you can always click into the details for the failed prow test, and click on open Raw build-log.txt to gain the full error logs. For example, this is the real reason why your test is failing. Link

And as prow suggested, you will need to rebase the PR as some newly merged changes on the main branch is conflicting with your current changes.

See the screenshot on how to find the

"Raw build-log.txt`

lmk if you have any other questions!

@yijie-04 There are still some goimports issue in your PR.

To fix the formatting issue, here are some practical commands you should be aware of:

1. go fmt ./... to format all the files in the project
2. goimports -w ./... will run go imports for all the files

When you are running these commands, you should be careful that we don't want to format the files in the vendor folder and the third_party folder.

And there is a convenient tool that I have made to combine the gofmt and goimport to a single command. Take a look at the source code to understand how that work and Just make sure run this script every time before you commit!

/retest-required
Looks like the failure is a flaky test @yijie-04 - don't worry about it

@Cali0707 @Leo6Leo Got it, thank you! I just finished formatting the files and I'll wait to see the test results. I do have some questions as I was formatting the code:

• I was running the commands for formatting earlier but nothing got changed (I also didn't receive any errors). However, after I had minikube running, the files were properly formatted. Why would formatting Go code require setting up a Kubernetes environment on my system?
• I'm also curious about the difference between the two commands, go fmt and goimports. It seems that all the files were formatted after running go fmt ./..., so what's the use of goimports?

Thanks a lot!

Hey @yijie-04, Great to hear that you've managed to format the files!! Let's address your questions:

1. Formatting Go Code and Kubernetes Environment:
   It's unusual that the Go code formatting seemed to require Minikube running. Typically, go fmt and goimports are independent of Kubernetes or any specific runtime environment. Their functionality is only focused on code formatting and organization.

2. Difference Between go fmt and goimports:
   The key difference lies in their functionality scope. go fmt is a more basic tool, part of the Go toolchain, focusing on making the code's formatting style standardized (for examples like indentations and spacing). On the other hand, goimports does everything go fmt does, but it also manages import lines - it adds missing import packages and removes unused ones. link This additional feature of goimports makes it particularly useful since Go is quite strict about import usage.

In short, while go fmt ensures your code is stylistically consistent, goimports also helps in maintaining clean and effective import statements.

Hope this clarifies your doubts! Don't hesitate to reach out if you have more questions!

/retest-required

@Leo6Leo That makes a lot more sense, thank you so much for the clarification!

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, yijie-04

The full list of commands accepted by this bot can be found here.

The pull request process is described here

@yijie-04 Congrats on the merging! Thanks for the effort you put into this and hope to see more contributions from you in Knative community!